Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sys.__stdout__ for terminal encoding check #15425

Closed
wants to merge 4 commits into from

Commits on Oct 31, 2022

  1. Use sys.__stdout__ for terminal encoding check

    It's common to redirect `sys.std*`. Currently, if you've redirected `sys.stdout` using a custom class and that class does not have an `encoding` attribute set,  `trainer.test` can fail with an `AttributeError`.  Since the `sys.stdout.encoding` check here concerns terminals, I propose using `sys.__stdout__` instead.
    nihir27 committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    91b64d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Configuration menu
    Copy the full SHA
    01db72c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4f71a54 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Configuration menu
    Copy the full SHA
    ca219f7 View commit details
    Browse the repository at this point in the history