Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimizer_closure return result #1516

Conversation

alexeykarnachev
Copy link
Contributor

@alexeykarnachev alexeykarnachev commented Apr 17, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1510 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 17, 2020 14:54
@alexeykarnachev alexeykarnachev changed the title optimizer_closure returns callback_metrics instead of output_dict Fix optimizer_closure return result Apr 17, 2020
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #1516 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1516   +/-   ##
======================================
- Coverage      91%     91%   -0%     
======================================
  Files          67      67           
  Lines        3784    3784           
======================================
- Hits         3439    3438    -1     
- Misses        345     346    +1     

@Borda Borda added the bug Something isn't working label Apr 17, 2020
@Borda Borda added this to the 0.7.4 milestone Apr 17, 2020
@williamFalcon
Copy link
Contributor

@alexeykarnachev
This fix won't work because the output of this goes into
training_epoch_end, which means things have to be tensors.

I'll submit a different PR to fix

@williamFalcon
Copy link
Contributor

williamFalcon commented Apr 19, 2020

Continuted in: #1528

@alexeykarnachev alexeykarnachev deleted the bug-fix-tensors-leak branch April 23, 2020 19:50
@Borda Borda modified the milestones: 0.7.4, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory (CPU and GPU) leaks during the 1st epoch
3 participants