Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wandb): allow use of sweeps #1512

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Conversation

borisdayma
Copy link
Contributor

@borisdayma borisdayma commented Apr 16, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
    not applicable
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1290 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

overwrite run config parameters due to precision error

fix Lightning-AI#1290
@mergify mergify bot requested a review from a team April 16, 2020 23:43
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #1512 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1512   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          68      68           
  Lines        3956    3956           
======================================
  Hits         3501    3501           
  Misses        455     455           

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a test for it

@Borda Borda added this to the 0.7.4 milestone Apr 17, 2020
@mergify mergify bot requested a review from a team April 17, 2020 07:00
@borisdayma
Copy link
Contributor Author

The test has been updated but the way it's set up, we only see that the function has been called -> see here

This is due to the fact that wandb uses context and it does not work well with pytest (there was some errors with some platforms tested such as windows).

Similar behavior happens with other loggers which also use mocks and verify only that the correct function has been called.

Adding another test overwriting a previous value would only check the same function has been called (so no more than current test scope).

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐰

@Borda Borda added bug Something isn't working ready PRs ready to be merged labels Apr 20, 2020
@mergify mergify bot requested a review from a team April 20, 2020 06:22
@mergify mergify bot requested a review from a team April 20, 2020 08:07
@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2020

This pull request is now in conflict... :(

@williamFalcon williamFalcon merged commit f3d139e into Lightning-AI:master Apr 24, 2020
@Borda Borda modified the milestones: 0.7.4, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(logger): wandb fails on sweep
4 participants