-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved docs for pytorch_lightning.core (continued) #1483
Merged
williamFalcon
merged 4 commits into
Lightning-AI:master
from
awaelchli:docs/improve_core
Apr 16, 2020
Merged
Improved docs for pytorch_lightning.core (continued) #1483
williamFalcon
merged 4 commits into
Lightning-AI:master
from
awaelchli:docs/improve_core
Apr 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update links add references to hooks lifecycle wip continue with __init__.py improve docs for memory.py improve docs for saving.py simpler links fix formatting
awaelchli
changed the title
Docs/improve core
Improved docs for pytorch_lightning.core (continued)
Apr 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #1483 +/- ##
======================================
Coverage 91% 91%
======================================
Files 67 67
Lines 3745 3745
======================================
Hits 3403 3403
Misses 342 342 |
justusschock
approved these changes
Apr 14, 2020
Borda
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Jun 7, 2020
* improved docs for core update links add references to hooks lifecycle wip continue with __init__.py improve docs for memory.py improve docs for saving.py simpler links fix formatting * move hooks lifecycle to top of file * fix doctest import problem * add missing hook in lifecycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
A continuation of a series of doc improvements. Follows #1389, #1370 and #1481.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃