Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on_before_zero_grad hook #1481

Closed
sebastienwood opened this issue Apr 13, 2020 · 3 comments · Fixed by #1483 or #1493
Closed

on_before_zero_grad hook #1481

sebastienwood opened this issue Apr 13, 2020 · 3 comments · Fixed by #1483 or #1493
Labels
docs Documentation related

Comments

@sebastienwood
Copy link

📚 Documentation

The documentation report the method on_before_zero_grad. Strangely, this method is not shown in the lifecycle for hooks documentation. Moreover, when it is defined in a lightning module it is not called.

Hence the question : is it a discontinued hook ? If so we could erase its mention in the docs.

Thanks.
@sebastienwood sebastienwood added the docs Documentation related label Apr 13, 2020
@github-actions
Copy link
Contributor

Hi! thanks for your contribution!, great first issue!

@awaelchli
Copy link
Member

awaelchli commented Apr 14, 2020 •
edited
Loading

Hi, thanks for catching that!
I added it in #1483 . Do you see any other hooks missing from the lifecycle?

@sebastienwood
Copy link
Author

@awaelchli not that I know !
It seems however that this particular hook is not called. Tried a few experiments and never reached it. The codebase doesn't seem to call it either.

@awaelchli awaelchli mentioned this issue Apr 14, 2020
Merged
5 tasks
@Borda Borda linked a pull request Apr 14, 2020 that will close this issue
Improved docs for pytorch_lightning.core (continued) #1483
Merged
5 tasks
@awaelchli awaelchli mentioned this issue Apr 14, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved docs for pytorch_lightning.core (continued)
Call on_before_zero_grad model hook
2 participants
@awaelchli @sebastienwood