Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

early stopping checks on_validation_end #1458

Merged
merged 13 commits into from
May 25, 2020
Merged

early stopping checks on_validation_end #1458

merged 13 commits into from
May 25, 2020

Commits on May 25, 2020

  1. Fixes Lightning-AI#490 

    `EarlyStopping` should check the metric of interest `on_validation_end` rather than `on_epoch_end`. 
In a normal scenario, this does not cause a problem, but in combination with `check_val_every_n_epoch>1` in the `Trainer` it results in a warning or in a `RuntimeError` depending on `strict`.
    @baldassarreFe @Borda
    baldassarreFe authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    006a067 View commit details
    Browse the repository at this point in the history

  2. Highlighted that ES callback runs on val epochs in docstring

    @baldassarreFe @Borda
    baldassarreFe authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    e4aedd1 View commit details
    Browse the repository at this point in the history

  3. Updated EarlyStopping in rst doc

    @baldassarreFe @Borda
    baldassarreFe authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    0a954a3 View commit details
    Browse the repository at this point in the history

  4. Update early_stopping.py

    @williamFalcon @Borda
    williamFalcon authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    1680c88 View commit details
    Browse the repository at this point in the history

  5. Update early_stopping.rst

    @williamFalcon @Borda
    williamFalcon authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    7f611ca View commit details
    Browse the repository at this point in the history

  6. Update early_stopping.rst

    @williamFalcon @Borda
    williamFalcon authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    4a4a30f View commit details
    Browse the repository at this point in the history

  7. Update early_stopping.rst

    @williamFalcon @Borda
    williamFalcon authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    a2a585f View commit details
    Browse the repository at this point in the history

  8. Update early_stopping.rst

    @williamFalcon @Borda
    williamFalcon authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    bcc0443 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
    @Borda @awaelchli
    Borda and awaelchli committed May 25, 2020
    Configuration menu
    Copy the full SHA
    55adddc View commit details
    Browse the repository at this point in the history

  10. Update docs/source/early_stopping.rst

    @awaelchli @Borda
    awaelchli authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    8650f07 View commit details
    Browse the repository at this point in the history

  11. fix doctest indentation warning

    @awaelchli @Borda
    awaelchli authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    095b32c View commit details
    Browse the repository at this point in the history

  12. Train loop calls early_stop.on_validation_end

    @baldassarreFe @Borda
    baldassarreFe authored and Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    3eba537 View commit details
    Browse the repository at this point in the history

  13. chlog

    @Borda
    Borda committed May 25, 2020
    Configuration menu
    Copy the full SHA
    f9c0ac5 View commit details
    Browse the repository at this point in the history