Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continues develop #1419

Merged
merged 3 commits into from
Apr 10, 2020
Merged

continues develop #1419

merged 3 commits into from
Apr 10, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 8, 2020

What does this PR do?

Just setting templates for further work...

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label Apr 8, 2020
@Borda Borda added this to the 0.7.3 milestone Apr 8, 2020
@Borda Borda requested a review from a team April 8, 2020 19:54
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #1419 into master will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #1419    +/-   ##
=======================================
  Coverage      91%     92%            
=======================================
  Files          66      63     -3     
  Lines        3552    3403   -149     
=======================================
- Hits         3239    3116   -123     
+ Misses        313     287    -26     

@mergify
Copy link
Contributor

mergify bot commented Apr 9, 2020

This pull request is now in conflict... :(

@williamFalcon williamFalcon merged commit dcda519 into master Apr 10, 2020
@Borda Borda modified the milestones: 0.7.4, 0.7.3 Apr 10, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
* continues develop

* changelog

* typo
@Borda Borda modified the milestones: 0.7.3, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants