Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader docs #1416

Merged
merged 13 commits into from
Apr 8, 2020
Merged

Loader docs #1416

merged 13 commits into from
Apr 8, 2020

Conversation

williamFalcon
Copy link
Contributor

update dataloader docs

@mergify mergify bot requested a review from a team April 8, 2020 13:06
@mergify mergify bot requested a review from a team April 8, 2020 13:15
@Borda Borda added the docs Documentation related label Apr 8, 2020
@williamFalcon
Copy link
Contributor Author

@awaelchli any thoughts on this? seems to be the sphinx extension.

image

@awaelchli
Copy link
Member

could you run pip install -r docs/requirements.txt just to be sure because CI doesn't seem to complain.

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #1416 into master will not change coverage by %.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1416   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          63      63           
  Lines        3384    3384           
======================================
  Hits         3104    3104           
  Misses        280     280           

@Borda
Copy link
Member

Borda commented Apr 8, 2020

also, there can be some forgetting files in source folder which were generated earlier (with apidoc) and now ar missing in the VCS...

@williamFalcon
Copy link
Contributor Author

ok, that fixed it.
But now we have these guys at the bottom. They shouldn't be there

image

@awaelchli
Copy link
Member

@williamFalcon See Lightning-Universe/lightning_sphinx_theme#10 for a fix for the navigation items

tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
* added multiple loader docs

* added multiple loader docs

* added multiple loader docs

* added multiple loader docs

* added multiple loader docs

* Apply suggestions from code review

* added multiple loader docs

* added build docs script

* typo

* added build docs script

* added build docs script

* added build docs script

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants