Pin sphinx version (fix for current docs build errors) #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
Borda
reviewed
Apr 5, 2020
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
Borda
added
docs
Codecov Report
@@ Coverage Diff @@
## master #1382 +/- ##
======================================
Coverage 92% 92%
======================================
Files 63 63
Lines 3323 3323
======================================
Hits 3051 3051
Misses 272 272 |
|
@Borda looks like github action is running sphinx 2.2, so 2.4 is too high? |
awaelchli
commented
Apr 5, 2020
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com>
jeremyjordan
approved these changes
Apr 5, 2020
justusschock
approved these changes
Apr 6, 2020
|
Great job! =) |
5 tasks
bmartinn
pushed a commit
to bmartinn/pytorch-lightning
that referenced
this pull request
Apr 6, 2020
…1382) * Update requirements.txt * Update docs/requirements.txt Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * freeze sphinx version * Update docs/source/conf.py Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Jun 7, 2020
…1382) * Update requirements.txt * Update docs/requirements.txt Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * freeze sphinx version * Update docs/source/conf.py Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes docs build error currently seen on master and in #1379, #1377
Was also suggested by @jeremyjordan
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃