Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added accumulation of loggers' metrics for the same steps #1278

Merged
merged 39 commits into from
Apr 8, 2020
Merged

Added accumulation of loggers' metrics for the same steps #1278

merged 39 commits into from
Apr 8, 2020

Commits on Apr 7, 2020

  1. add_argparse_args method fixed (argument types added)

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    c5c467e View commit details
    Browse the repository at this point in the history

  2. autopep8 fixes

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    625c01a View commit details
    Browse the repository at this point in the history

  3. --gpus=0 removed from test (for ci tests)

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    05b9d55 View commit details
    Browse the repository at this point in the history

  4. Update pytorch_lightning/trainer/trainer.py 

    Co-Authored-By: Joe Davison <joe@huggingface.co>
    @alexeykarnachev @Borda
    2 people authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    a14da90 View commit details
    Browse the repository at this point in the history

  5. test_with_accumulate_grad_batches added

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    30d0347 View commit details
    Browse the repository at this point in the history

  6. agg_and_log_metrics logic added to the base logger class

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    f222da1 View commit details
    Browse the repository at this point in the history

  7. small format fix

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    0d69480 View commit details
    Browse the repository at this point in the history

  8. agg metrics strategies removed (not to complicate stuff)

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    40812f8 View commit details
    Browse the repository at this point in the history

  9. agg metrics: handle zero step

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    06f450c View commit details
    Browse the repository at this point in the history

  10. autopep8

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    c4ee89b View commit details
    Browse the repository at this point in the history

  11. changelog upd

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    d206a13 View commit details
    Browse the repository at this point in the history

  12. flake fix

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    aa22904 View commit details
    Browse the repository at this point in the history

  13. metrics aggregators factored out, metrics_agg.py added + tests

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    bab529d View commit details
    Browse the repository at this point in the history

  14. metrics agg default value added

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    39745aa View commit details
    Browse the repository at this point in the history

  15. Update pytorch_lightning/loggers/metrics_agg.py 

    Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
    @alexeykarnachev @Borda
    alexeykarnachev and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    73a724a View commit details
    Browse the repository at this point in the history

  16. remove .item which causes sync issues (Lightning-AI#1254) 

    * remove .item which causes sync issues

* fixed gradient acc sched

* fixed gradient acc sched
    @williamFalcon @Borda
    williamFalcon authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    c586217 View commit details
    Browse the repository at this point in the history

  17. test_metrics_agg.py removed (all tested in doctrings), agg metrics re… 

    …factored
    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    e48a711 View commit details
    Browse the repository at this point in the history

  18. autopep8

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    8064470 View commit details
    Browse the repository at this point in the history

  19. loggers base.py types fixed

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    b11a80e View commit details
    Browse the repository at this point in the history

  20. test

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    8e7e28f View commit details
    Browse the repository at this point in the history

  21. test

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    1143294 View commit details
    Browse the repository at this point in the history

  22. metrics aggregation for loggers: each key now has a specific function… 

    … (or default one)
    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    a04f2c3 View commit details
    Browse the repository at this point in the history

  23. metrics aggregators factored out, metrics_agg.py added + tests

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    94dd1f8 View commit details
    Browse the repository at this point in the history

  24. metrics agg default value added

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    7ba9c96 View commit details
    Browse the repository at this point in the history

  25. Update pytorch_lightning/loggers/metrics_agg.py 

    Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
    @alexeykarnachev @Borda
    alexeykarnachev and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    e9fc69a View commit details
    Browse the repository at this point in the history

  26. test_metrics_agg.py removed (all tested in doctrings), agg metrics re… 

    …factored
    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    6b90977 View commit details
    Browse the repository at this point in the history

  27. metrics aggregation for loggers: each key now has a specific function… 

    … (or default one)
    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    41aff77 View commit details
    Browse the repository at this point in the history

  28. docstrings upd

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    2fd1c79 View commit details
    Browse the repository at this point in the history

  29. manual typehints removed from docstrings

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    5afe31d View commit details
    Browse the repository at this point in the history

  30. batch_size decreased for test test_with_accumulate_grad_batches

    @Borda
    akarnachev authored and Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    56a9b71 View commit details
    Browse the repository at this point in the history

  31. extend running accum

    @Borda
    Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    c6ab2e0 View commit details
    Browse the repository at this point in the history

  32. refactor

    @Borda
    Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    014b6dd View commit details
    Browse the repository at this point in the history

  33. fix tests

    @Borda
    Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    0cf3122 View commit details
    Browse the repository at this point in the history

  34. fix tests

    @Borda
    Borda committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    64ac60e View commit details
    Browse the repository at this point in the history

  35. allowed_types generator scoped

    @alexeykarnachev
    alexeykarnachev committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    2ecb8c5 View commit details
    Browse the repository at this point in the history

  36. trainer.py distutils was imported twice, fixed

    @alexeykarnachev
    alexeykarnachev committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    382aadb View commit details
    Browse the repository at this point in the history

  37. TensorRunningAccum refactored

    @alexeykarnachev
    alexeykarnachev committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    80da0fb View commit details
    Browse the repository at this point in the history

  38. TensorRunningAccum added to change log (Changed)

    @alexeykarnachev
    alexeykarnachev committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    6b64fde View commit details
    Browse the repository at this point in the history

  39. change log pull link added

    @alexeykarnachev
    alexeykarnachev committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    5f1f557 View commit details
    Browse the repository at this point in the history