Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizer Frequencies logic, and new configure_optimizers #1269

Merged
merged 16 commits into from
Mar 31, 2020
Merged

Optimizer Frequencies logic, and new configure_optimizers #1269

merged 16 commits into from
Mar 31, 2020

Commits on Mar 28, 2020

  1. init_optimizers accepts Dict, Sequence[Dict] 

    and returns optimizer_frequencies.
optimizer_frequencies was added as a member of Trainer.
    @asafmanor
    asafmanor committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    717d592 View commit details
    Browse the repository at this point in the history

  2. Optimizer frequencies logic implemented in training_loop. 

    Description added to configure_optimizers in LightningModule
    @asafmanor
    asafmanor committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    3340b46 View commit details
    Browse the repository at this point in the history

  3. optimizer frequencies tests added to test_gpu

    @asafmanor
    asafmanor committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    cb1a9e1 View commit details
    Browse the repository at this point in the history

  4. Fixed formatting for merging PR #1269

    @asafmanor
    asafmanor committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    3c1d037 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review

    @Borda
    Borda committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    9433a5c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Asaf Manor <32155911+asafmanor@users.noreply.github.com>
    @Borda @asafmanor
    Borda and asafmanor committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    0d1dab5 View commit details
    Browse the repository at this point in the history

  2. Update trainer.py

    @Borda
    Borda committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    c8251db View commit details
    Browse the repository at this point in the history

  3. Moving get_optimizers_iterable() outside.

    @asafmanor
    asafmanor committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    dceb0df View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Update note

    @Borda
    Borda committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    b1a5cec View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @Borda
    Borda committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    fdebe67 View commit details
    Browse the repository at this point in the history

  3. formatting

    @Borda
    Borda committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    d629909 View commit details
    Browse the repository at this point in the history

  4. formatting

    @Borda
    Borda committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    62bf808 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG.md

    @asafmanor
    asafmanor committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    f03a524 View commit details
    Browse the repository at this point in the history

  6. formatting

    @Borda
    Borda committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    ef6af0e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into master

    @asafmanor
    asafmanor committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    7cfe6c0 View commit details
    Browse the repository at this point in the history

  8. Update CHANGELOG.md

    @Borda
    Borda committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    623d953 View commit details
    Browse the repository at this point in the history