Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default benchmark based on deterministic flag #11944

Merged
merged 23 commits into from
Feb 24, 2022
Merged

Default benchmark based on deterministic flag #11944

merged 23 commits into from
Feb 24, 2022

Conversation

krshrimali
Copy link
Contributor

What does this PR do?

  • This PR makes the benchmark flag of Trainer class Optional, and defaults to the value based on deterministic flag. Also allows manually overwriting the flag.
  • Why not deprecate? We wish to allow overwriting the flag by the users, and prevent BC-breaking changes.
  • Tests have been updated accordingly.

Fixes #9128.

Does your PR introduce any breaking changes? If yes, please list them.

No!

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Thanks to @carmocca for helping me with this PR. 🎉

@carmocca carmocca added this to the 1.6 milestone Feb 16, 2022
@carmocca carmocca added feature Is an improvement or enhancement trainer: argument labels Feb 16, 2022
carmocca
carmocca approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I pushed one commit with docs changes after searching for how to properly reference another parameter. Also added one reference to PyTorch's docs about randomness.

@krshrimali @carmocca
Update tests/trainer/test_trainer.py
8d3275c 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
kaushikb11
kaushikb11 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added the ready PRs ready to be merged label Feb 17, 2022
@mergify mergify bot removed the has conflicts label Feb 18, 2022
@awaelchli awaelchli mentioned this pull request Feb 19, 2022
Closed
10 tasks
@timesler timesler mentioned this pull request Feb 20, 2022
Closed
12 tasks
@krshrimali @awaelchli
Update CHANGELOG.md
d3dcdee 
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@mergify mergify bot removed the has conflicts label Feb 22, 2022
awaelchli
awaelchli approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTLM

rohitgr7
rohitgr7 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
small comments.

docs/source/common/trainer.rst Outdated Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
@krshrimali @rohitgr7
Apply suggestions from code review
7fb9ed6 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
carmocca
carmocca approved these changes Feb 23, 2022
View reviewed changes
pytorch_lightning/trainer/connectors/accelerator_connector.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/accelerator_connector.py Outdated Show resolved Hide resolved
docs/source/common/trainer.rst Outdated Show resolved Hide resolved
@krshrimali @carmocca
Apply suggestions from code review
f4a96c4 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@carmocca carmocca enabled auto-merge (squash) February 23, 2022 13:55
rohitgr7 and others added 3 commits February 23, 2022 20:06
carmocca
carmocca reviewed Feb 24, 2022
View reviewed changes
tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
@carmocca carmocca merged commit 00211c1 into Lightning-AI:master Feb 24, 2022
@carmocca carmocca mentioned this pull request May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub left review comments

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@awaelchli awaelchli awaelchli approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees

@krshrimali krshrimali

Labels
feature Is an improvement or enhancement ready PRs ready to be merged trainer: argument
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[RFC] Depreceate Trainer(benchmark) and use deterministic
6 participants
@krshrimali @ananthsub @awaelchli @carmocca @rohitgr7 @kaushikb11