Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Wandb callback's finalize with no-op #1193

Merged
merged 8 commits into from
Mar 30, 2020
Merged

Replace Wandb callback's finalize with no-op #1193

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e33a956
Replace Wandb callback's finalize with no-op
bilal2vec Mar 19, 2020
68f1fc7
Merge branch 'master' into wandb-fix
Borda Mar 25, 2020
2de5093
Update pytorch_lightning/loggers/wandb.py
Borda Mar 25, 2020
a681ae7
Update wandb.py
Borda Mar 25, 2020
7f67a53
remove wandb logger's finalize and update tests
bilal2vec Mar 30, 2020
4cd5bab
update changelog
bilal2vec Mar 30, 2020
ea5bc74
Merge remote-tracking branch 'upstream/master' into wandb-fix
bilal2vec Mar 30, 2020
cf6fc29
Merge branch 'master' into wandb-fix
williamFalcon Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pytorch_lightning/loggers/wandb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ def finalize(self, status: str = 'success') -> None:
wandb.join(exit_code)
except TypeError:
wandb.join()
return exit_code
Borda marked this conversation as resolved.
Show resolved Hide resolved

@property
def name(self) -> str:
Expand Down