Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom argparser extension with Trainer arguments (argument types added) #1147

Merged
merged 59 commits into from
Mar 24, 2020
Merged

Custom argparser extension with Trainer arguments (argument types added) #1147

merged 59 commits into from
Mar 24, 2020

Commits on Mar 14, 2020

  1. add_argparse_args method fixed (argument types added)

    akarnachev committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    ea6b8f1 View commit details
    Browse the repository at this point in the history

  2. CHANGELOG.md upd

    akarnachev committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    28e9348 View commit details
    Browse the repository at this point in the history

  3. autopep8 fixes

    akarnachev committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    6c290dd View commit details
    Browse the repository at this point in the history

  4. --gpus=0 removed from test (for ci tests)

    akarnachev committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    4444701 View commit details
    Browse the repository at this point in the history

  5. typo fixed

    akarnachev committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    0ec101f View commit details
    Browse the repository at this point in the history

  6. reduce on plateau scheduler fixed

    akarnachev committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    bc7dd6f View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Trainer cli related tests moved to test_trainer_cli.py

    akarnachev committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    57a22ea View commit details
    Browse the repository at this point in the history

  2. refactored: get_init_arguments_and_types is a public classmethod of t… 

    …he Trainer now
    akarnachev committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    2d220d5 View commit details
    Browse the repository at this point in the history

  3. test_get_init_arguments_and_types added

    akarnachev committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    5b5042e View commit details
    Browse the repository at this point in the history

  4. autopep8 fixes

    akarnachev committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    dd81a39 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master'

    akarnachev committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    b4d9605 View commit details
    Browse the repository at this point in the history

  6. Trainer cli related tests moved to test_trainer_cli.py

    akarnachev committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    977b2de View commit details
    Browse the repository at this point in the history

  7. refactored: get_init_arguments_and_types is a public classmethod of t… 

    …he Trainer now
    akarnachev committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    7a9ba50 View commit details
    Browse the repository at this point in the history

  8. test_get_init_arguments_and_types added

    akarnachev committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    551ff24 View commit details
    Browse the repository at this point in the history

  9. autopep8 fixes

    akarnachev committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    d3c1fdc View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/trainer-argparser-types' into tr… 

    …ainer-argparser-types
    akarnachev committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    1f92d92 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. merged

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    2b27e3c View commit details
    Browse the repository at this point in the history

  2. Trainer cli related tests moved to test_trainer_cli.py

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    f501ce6 View commit details
    Browse the repository at this point in the history

  3. refactored: get_init_arguments_and_types is a public classmethod of t… 

    …he Trainer now
    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    4bccfd7 View commit details
    Browse the repository at this point in the history

  4. test_get_init_arguments_and_types added

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    38dcba7 View commit details
    Browse the repository at this point in the history

  5. autopep8 fixes

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    e1abf4d View commit details
    Browse the repository at this point in the history

  6. Trainer cli related tests moved to test_trainer_cli.py

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    ea3334a View commit details
    Browse the repository at this point in the history

  7. test_get_init_arguments_and_types added

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    f79dcbf View commit details
    Browse the repository at this point in the history

  8. autopep8 fixes

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    299574d View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/trainer-argparser-types' into tr… 

    …ainer-argparser-types
    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    4782fe6 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review

    @Borda
    Borda committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    20c4073 View commit details
    Browse the repository at this point in the history

  11. cosmetics

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    201d855 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/trainer-argparser-types' into tr… 

    …ainer-argparser-types

# Conflicts:
#	tests/trainer/test_trainer_cli.py
    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    567d9b8 View commit details
    Browse the repository at this point in the history

  13. cosmetics

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    0c292b4 View commit details
    Browse the repository at this point in the history

  14. Update pytorch_lightning/trainer/trainer.py 

    Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
    @alexeykarnachev @Borda
    alexeykarnachev and Borda committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    f45fa6f View commit details
    Browse the repository at this point in the history

  15. Trainer.get_init_arguments_and_types now returns arg types wrapped … 

    …in tuples (not in sets)
    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    eb23637 View commit details
    Browse the repository at this point in the history

  16. deprecated args are now ignored in argparser

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    5f4a5fe View commit details
    Browse the repository at this point in the history

  17. get_deprecated_arg_names small refactor

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    f48f17e View commit details
    Browse the repository at this point in the history

  18. get_deprecated_arg_names bug fixed

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    2207c4e View commit details
    Browse the repository at this point in the history

  19. Trainer cli related tests moved to test_trainer_cli.py

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    0a73a34 View commit details
    Browse the repository at this point in the history

  20. refactored: get_init_arguments_and_types is a public classmethod of t… 

    …he Trainer now
    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    0cd9aaa View commit details
    Browse the repository at this point in the history

  21. test_get_init_arguments_and_types added

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    25bd99d View commit details
    Browse the repository at this point in the history

  22. autopep8 fixes

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    5253a50 View commit details
    Browse the repository at this point in the history

  23. Trainer cli related tests moved to test_trainer_cli.py

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    3fd9a99 View commit details
    Browse the repository at this point in the history

  24. autopep8 fixes

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    36ca20b View commit details
    Browse the repository at this point in the history

  25. Trainer cli related tests moved to test_trainer_cli.py

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    f7cc4e1 View commit details
    Browse the repository at this point in the history

  26. autopep8 fixes

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    ce837fe View commit details
    Browse the repository at this point in the history

  27. Trainer cli related tests moved to test_trainer_cli.py

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    8aa062a View commit details
    Browse the repository at this point in the history

  28. test_get_init_arguments_and_types added

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    d447aa3 View commit details
    Browse the repository at this point in the history

  29. autopep8 fixes

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    aaada85 View commit details
    Browse the repository at this point in the history

  30. Apply suggestions from code review

    @Borda
    Borda authored and akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    87b6cbb View commit details
    Browse the repository at this point in the history

  31. cosmetics

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    a9f996b View commit details
    Browse the repository at this point in the history

  32. cosmetics

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    a4702ff View commit details
    Browse the repository at this point in the history

  33. Update pytorch_lightning/trainer/trainer.py 

    Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
    @alexeykarnachev @Borda
    2 people authored and akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    162f3ab View commit details
    Browse the repository at this point in the history

  34. Trainer.get_init_arguments_and_types now returns arg types wrapped … 

    …in tuples (not in sets)
    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    a8b21d9 View commit details
    Browse the repository at this point in the history

  35. deprecated args are now ignored in argparser

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    2a5d46d View commit details
    Browse the repository at this point in the history

  36. get_deprecated_arg_names small refactor

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    3b7c865 View commit details
    Browse the repository at this point in the history

  37. get_deprecated_arg_names bug fixed

    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    d07870d View commit details
    Browse the repository at this point in the history

  38. Merge remote-tracking branch 'origin/trainer-argparser-types' into tr… 

    …ainer-argparser-types
    akarnachev committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    012d425 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Merge branch 'master' into trainer-argparser-types

    @Borda
    Borda committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    9449b98 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Update pytorch_lightning/trainer/trainer.py 

    Co-Authored-By: Joe Davison <joe@huggingface.co>
    @alexeykarnachev
    alexeykarnachev and Joe Davison committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    94c5e09 View commit details
    Browse the repository at this point in the history

  2. Update pytorch_lightning/trainer/trainer.py 

    Co-Authored-By: Joe Davison <joe@huggingface.co>
    @alexeykarnachev
    alexeykarnachev and Joe Davison committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    4f8314d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into trainer-argparser-types

    @Borda
    Borda committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    77847b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Merge branch 'master' into trainer-argparser-types

    @williamFalcon
    williamFalcon committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    63d30fd View commit details
    Browse the repository at this point in the history