Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Strategy.init_optimizers #11236

Merged
merged 12 commits into from
Dec 23, 2021

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Dec 23, 2021

What does this PR do?

After #11155, we can remove Strategy.init_optimizers and consolidate in Strategy.setup_optimizers.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot added the ready PRs ready to be merged label Dec 23, 2021
@Borda
Copy link
Member

Borda commented Dec 23, 2021

Could we pls use the checklist in the PR template? 🐰

pytorch_lightning/core/optimizer.py Outdated Show resolved Hide resolved
pytorch_lightning/core/optimizer.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Dec 23, 2021
pytorch_lightning/core/optimizer.py Outdated Show resolved Hide resolved
@daniellepintz
Copy link
Contributor Author

Ready to be merged!

@ananthsub ananthsub enabled auto-merge (squash) December 23, 2021 18:00
@daniellepintz daniellepintz added this to the 1.6 milestone Dec 23, 2021
@ananthsub ananthsub merged commit ca9b25d into Lightning-AI:master Dec 23, 2021
@daniellepintz daniellepintz deleted the refactor_init_optimizer branch December 23, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants