change default logger to dedicated one #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey there, we have added GPU CI test, so could we kindly ask to rebase/merge master which will trigger these tests so we do not need to test it manually... Thx for your understanding 🤖 |
|
Done! |
awaelchli
reviewed
Mar 14, 2020
awaelchli
reviewed
Mar 14, 2020
|
Fixed |
Borda
requested changes
Mar 15, 2020
|
Rebased & fixed |
Codecov Report
@@ Coverage Diff @@
## master #1064 +/- ##
=======================================
+ Coverage 89% 93% +4%
=======================================
Files 62 61 -1
Lines 3163 2671 -492
=======================================
- Hits 2809 2471 -338
+ Misses 354 200 -154 |
Borda
approved these changes
Mar 16, 2020
|
About the docs, I didn't read into them carefully so I think I can make improvements after I'm more familiar with the framework |
Fix test Fix format Update pytorch_lightning/__init__.py Separate imports
|
Rebased |
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
Fix test Fix format Update pytorch_lightning/__init__.py Separate imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Changed the default logger to
logging.getLogger("lightning")as proposed here: #710 (comment)This modification won't make any difference to current users since the logging will propagate to root logger. However if the user want to distinguish the text log from pytorch-lightning from logs of other packages, they have an option now.