test

Lightning-AI · Jun 19, 2020 · f99e893 · f99e893
1 parent 297c4f6
commit f99e893
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -69,7 +69,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
   * `test_percent_check` in favour of `limit_test_batches`
 - Deprecated `ModelCheckpoint`'s attributes `best` and `kth_best_model` ([#1799](https://github.com/PyTorchLightning/pytorch-lightning/pull/1799))
 - Dropped official support/testing for older PyTorch versions <1.3 ([#1917](https://github.com/PyTorchLightning/pytorch-lightning/pull/1917))
-- Deprecated Trainer `proc_rank` in favour of `global_rank` ([#2166](https://github.com/PyTorchLightning/pytorch-lightning/pull/2166), )
+- Deprecated Trainer `proc_rank` in favour of `global_rank` ([#2166](https://github.com/PyTorchLightning/pytorch-lightning/pull/2166), [#2269](https://github.com/PyTorchLightning/pytorch-lightning/pull/2269))
 
 ### Removed
 

diff --git a/tests/test_deprecated.py b/tests/test_deprecated.py
@@ -44,6 +44,12 @@ def test_tbd_remove_in_v0_10_0_trainer():
     with pytest.deprecated_call(match='v0.10.0'):
         assert trainer.test_percent_check == rnd_val
 
+    trainer = Trainer()
+    with pytest.deprecated_call(match='v0.10.0'):
+        trainer.proc_rank = 0
+    with pytest.deprecated_call(match='v0.10.0'):
+        assert trainer.proc_rank == trainer.global_rank
+
 
 def test_tbd_remove_in_v0_9_0_trainer():
     # test show_progress_bar set by progress_bar_refresh_rate