Move logger initialization (#750)

pytorch_lightning/trainer/callback_config.py

@@ -2,7 +2,6 @@
 from abc import ABC
 
 from pytorch_lightning.callbacks import ModelCheckpoint, EarlyStopping
-from pytorch_lightning.logging import TensorBoardLogger
 
 
 class TrainerCallbackConfigMixin(ABC):
@@ -50,7 +49,7 @@ def configure_checkpoint_callback(self):
         if self.weights_save_path is None:
             self.weights_save_path = self.default_save_path
 
-    def configure_early_stopping(self, early_stop_callback, logger):
+    def configure_early_stopping(self, early_stop_callback):
         if early_stop_callback is True:
             self.early_stop_callback = EarlyStopping(
                 monitor='val_loss',
@@ -75,18 +74,3 @@ def configure_early_stopping(self, early_stop_callback, logger):
         else:
             self.early_stop_callback = early_stop_callback
             self.enable_early_stop = True
-
-        # configure logger
-        if logger is True:
-            # default logger
-            self.logger = TensorBoardLogger(
-                save_dir=self.default_save_path,
-                version=self.slurm_job_id,
-                name='lightning_logs'
-            )
-            self.logger.rank = 0
-        elif logger is False:
-            self.logger = None
-        else:
-            self.logger = logger
-            self.logger.rank = 0

pytorch_lightning/trainer/logging.py

@@ -3,6 +3,7 @@
 import torch
 
 from pytorch_lightning.core import memory
+from pytorch_lightning.logging import TensorBoardLogger
 
 
 class TrainerLoggingMixin(ABC):
@@ -21,6 +22,21 @@ def __init__(self):
         self.use_ddp2 = None
         self.num_gpus = None
 
+    def configure_logger(self, logger):
+        if logger is True:
+            # default logger
+            self.logger = TensorBoardLogger(
+                save_dir=self.default_save_path,
+                version=self.slurm_job_id,
+                name='lightning_logs'
+            )
+            self.logger.rank = 0
+        elif logger is False:
+            self.logger = None
+        else:
+            self.logger = logger
+            self.logger.rank = 0
+
     def log_metrics(self, metrics, grad_norm_dic, step=None):
         """Logs the metric dict passed in.
 

pytorch_lightning/trainer/trainer.py

@@ -558,10 +558,12 @@ def __init__(
         self.current_epoch = 0
         self.total_batches = 0
 
+        # configure logger
+        self.configure_logger(logger)
+
         # configure early stop callback
         # creates a default one if none passed in
-        self.early_stop_callback = None
-        self.configure_early_stopping(early_stop_callback, logger)
+        self.configure_early_stopping(early_stop_callback)
 
         self.reduce_lr_on_plateau_scheduler = None