Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phi-3 prompt template #1544

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Update phi-3 prompt template #1544

merged 2 commits into from
Jul 2, 2024

Conversation

rasbt
Copy link
Collaborator

@rasbt rasbt commented Jul 2, 2024

Coincidentally, after we merged the Phi-3 checkpoint, Microsoft silently made some updates to Phi-3:

Screenshot 2024-07-02 at 9 38 54 AM

This includes the prompt template, which is now

<|system|>
You are a helpful assistant.<|end|>
<|user|>
hello world
<|assistant|>

and the removal of the double-BOS token.

@rasbt rasbt marked this pull request as draft July 2, 2024 14:39
@rasbt rasbt marked this pull request as ready for review July 2, 2024 14:42
@rasbt
Copy link
Collaborator Author

rasbt commented Jul 2, 2024

Please let me know if these changes look good @Andrei-Aksionov 😊

@Andrei-Aksionov
Copy link
Collaborator

Obviously, they held back these changes till LitGPT supports the model 😆.

Andrei-Aksionov
Andrei-Aksionov approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@Andrei-Aksionov Andrei-Aksionov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@rasbt rasbt merged commit 2da3dd2 into main Jul 2, 2024
9 checks passed
@rasbt rasbt deleted the update-phi-3 branch July 2, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrei-Aksionov Andrei-Aksionov Andrei-Aksionov approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasbt @Andrei-Aksionov