Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: use rsa instead of openssl #116

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

kwaa
Copy link
Contributor

@kwaa kwaa commented Jul 10, 2024

closed #49

cc @Nutomic

This PR uses rsa crate instead of openssl to make the project more portable.

The private_key here looks isn't in pkcs8 format, so I've used from_pkcs1_pem here.

@kwaa kwaa marked this pull request as ready for review July 10, 2024 16:20
@Nutomic
Copy link
Member

Nutomic commented Jul 10, 2024

Very nice! To fix the test failure you need to merge commits from main branch to yours.

@kwaa
Copy link
Contributor Author

kwaa commented Jul 11, 2024

To fix the test failure you need to merge commits from main branch to yours.

The master branch doesn't seem to have any new commits. https://github.com/LemmyNet/activitypub-federation-rust/commits/main/

@Nutomic
Copy link
Member

Nutomic commented Jul 11, 2024

My bad, I didnt commit/push my change 🤦

#117

Cargo.toml Show resolved Hide resolved

[dev-dependencies]
anyhow = "1.0.82"
rand = "0.8.5"
env_logger = "0.11.3"
tower-http = { version = "0.5.2", features = ["map-request-body", "util"] }
axum = { version = "0.6.20", features = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might as well add the toml formatting to CI. You can copy it from the Lemmy repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might as well add the toml formatting to CI. You can copy it from the Lemmy repo.

I'll take a look, but maybe changing CI as another PR would be better.

Copy link
Member

@Nutomic Nutomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive confirmed that Lemmy federation tests are passing with these changes. So you just need to pull in the test fix in order to merge.

@kwaa
Copy link
Contributor Author

kwaa commented Jul 11, 2024

Ive confirmed that Lemmy federation tests are passing with these changes. So you just need to pull in the test fix in order to merge.

I updated the branch.

@Nutomic Nutomic merged commit 8f47daa into LemmyNet:main Jul 15, 2024
1 check passed
@kwaa kwaa deleted the fxxk-openssl branch July 15, 2024 08:24
@dessalines
Copy link
Member

This should also probably be done for lemmy too. I'll open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from OpenSSL to Rustls
3 participants