-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: use rsa
instead of openssl
#116
Conversation
Very nice! To fix the test failure you need to merge commits from main branch to yours. |
The master branch doesn't seem to have any new commits. https://github.com/LemmyNet/activitypub-federation-rust/commits/main/ |
My bad, I didnt commit/push my change 🤦 |
|
||
[dev-dependencies] | ||
anyhow = "1.0.82" | ||
rand = "0.8.5" | ||
env_logger = "0.11.3" | ||
tower-http = { version = "0.5.2", features = ["map-request-body", "util"] } | ||
axum = { version = "0.6.20", features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might as well add the toml formatting to CI. You can copy it from the Lemmy repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might as well add the toml formatting to CI. You can copy it from the Lemmy repo.
I'll take a look, but maybe changing CI as another PR would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive confirmed that Lemmy federation tests are passing with these changes. So you just need to pull in the test fix in order to merge.
I updated the branch. |
This should also probably be done for lemmy too. I'll open an issue. |
closed #49
cc @Nutomic
This PR uses
rsa
crate instead ofopenssl
to make the project more portable.The private_key here looks isn't in pkcs8 format, so I've used
from_pkcs1_pem
here.