Production-like build on dev PC #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/prod-like-build.sh
Outdated
| docker run \ | ||
| --mount type=bind,source="$(pwd)"/artifacts,target=/hostdir \ | ||
| lib-ledger-core-build-env:latest \ | ||
| /scripts/prod-like-build-inner.sh Debug |
There was a problem hiding this comment.
Maybe we want to duplicate this file to have dev-like-build or something?
There was a problem hiding this comment.
Moved this to command arguments. By default it builds Release. Debug if explicitly specified.
jcoatelen-ledger
requested changes
Aug 11, 2022
Done |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LedgerHQ/lib-ledger-core-build-envledger-lib-core.jarAttn: default paths to jre libraries are different in prod and on typical dev machine.
LD_LIBRARY_PATHmust be modified accordingly to run WD:This PR depends on https://github.com/LedgerHQ/lib-ledger-core-build-env/pull/9