Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing abi filter configuration #224 #225

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Fix missing abi filter configuration #224 #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d77ca4c
fix abi filter configuration #224
wuan Jan 24, 2023
d555aab
Merge branch 'main' into fix_abi_filter
wuan Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ android {
// Recommended by Google Play Store for testing
// https://developer.android.com/reference/tools/gradle-api/6.7/com/android/build/api/dsl/Ndk
debugSymbolLevel 'SYMBOL_TABLE'
abiFilters 'arm64-v8a', 'armeabi-v7a', 'x86_64'
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true
android.enableJetifier=true
AndroidProject.signing=/Users/donataspuidokas/key.properties
AndroidProject.signing=./key.properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be extra careful, I wanted to push this file out of project directory as it contains sensitive information

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The local .gitignore already contains a line which should avoid checking in the file:

...
# Remember to never publicly share your keystore.
# See https://flutter.dev/docs/deployment/android#reference-the-keystore-from-the-app
key.properties
...


2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ publish_to: "none" # Remove this line if you wish to publish to pub.dev
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.3+31
version: 1.0.3+34

environment:
sdk: ">=2.12.0 <3.4.0"
Expand Down