Build iOS version

.github/workflows/build.yml

@@ -14,7 +14,7 @@ jobs:
 
     steps:
       - name: "Checkout"
-        uses: "actions/checkout@v2"
+        uses: "actions/checkout@v3"
         with:
           submodules: "recursive"
 
@@ -40,7 +40,7 @@ jobs:
 
       # We are building debug version APK which can be manually install, however it cannot be reused for upload to store 
       - name: "Build debug apk"
-        run: "flutter build apk lib/main_la.dart -v --dart-define version=${{ env.DESTINY_VERSION }} --build-name ${{ env.DESTINY_VERSION }} --debug"
+        run: "flutter build apk lib/main_la.dart --dart-define version=${{ env.DESTINY_VERSION }} --build-name ${{ env.DESTINY_VERSION }} --debug"
 
       - name: "Move apk"
         run: mv ./build/app/outputs/flutter-apk/app-debug.apk destiny_android_${{ env.DESTINY_VERSION }}.apk
@@ -65,7 +65,7 @@ jobs:
 
     steps:
       - name: "Checkout"
-        uses: "actions/checkout@v2"
+        uses: "actions/checkout@v3"
         with:
           submodules: "recursive"
 
@@ -96,7 +96,7 @@ jobs:
         run: "sudo apt update && sudo apt install ninja-build libgtk-3-dev libgtkmm-3.0-dev libfuse2"
 
       - name: "Build for linux"
-        run: "flutter build linux lib/main_la.dart -v --dart-define version=${{ env.DESTINY_VERSION }}"
+        run: "flutter build linux lib/main_la.dart --dart-define version=${{ env.DESTINY_VERSION }}"
 
       - name: "rpath workaround"
         run: |
@@ -143,7 +143,7 @@ jobs:
 
     steps:
       - name: "Checkout"
-        uses: "actions/checkout@v2"
+        uses: "actions/checkout@v3"
         with:
           submodules: "recursive"
 
@@ -173,7 +173,7 @@ jobs:
         run: "flutter config --enable-macos-desktop"
 
       - name: "Build mac app"
-        run: "flutter build macos lib/main_la.dart --debug -v --dart-define version=${{ env.DESTINY_VERSION }} --build-name ${{ env.DESTINY_VERSION }}"
+        run: "flutter build macos lib/main_la.dart --debug --dart-define version=${{ env.DESTINY_VERSION }} --build-name ${{ env.DESTINY_VERSION }}"
 
       - name: "Install create-dmg"
         run: "brew install create-dmg"
@@ -196,12 +196,48 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
         if: ${{ github.ref_type == 'tag' }}
 
+  ios:
+    runs-on: macos-latest
+
+    steps:
+      - name: "Checkout"
+        uses: "actions/checkout@v3"
+        with:
+          submodules: "recursive"
+
+      - name: "Set version string for release"
+        run: echo DESTINY_VERSION=${{ github.ref_name }} >> $GITHUB_ENV
+        if: ${{ github.ref_type == 'tag' }}
+
+      - name: "Set version string for branch"
+        run: echo DESTINY_VERSION=${{ github.head_ref }} >> $GITHUB_ENV
+        if: ${{ github.ref_type != 'tag' }}
+
+      - name: "Setup flutter"
+        uses: "subosito/flutter-action@v2.4.0"
+
+      - name: "Fetch flutter dependencies"
+        run: "flutter pub get"
+
+      # TODO remove the || true when this should be enforced
+      # Right now it is just informational
+      - name: "Lint"
+        run: "flutter analyze || true"
+
+      - name: "Style check"
+        run: "flutter format --set-exit-if-changed lib test"
+
+      - name: "Build ios app (only for simulator)"
+        run: |
+          export GOROOT=`go env GOROOT` 
+          flutter build ios lib/main_la.dart --debug --simulator --no-codesign --dart-define version=${{ env.DESTINY_VERSION }} --build-name ${{ env.DESTINY_VERSION }}
+
   windows:
     runs-on: windows-latest
 
     steps:
       - name: "Checkout"
-        uses: "actions/checkout@v2"
+        uses: "actions/checkout@v3"
         with:
           submodules: "recursive"
 
@@ -226,7 +262,7 @@ jobs:
         run: "flutter format --set-exit-if-changed lib test"
 
       - name: "Build windows"
-        run: "flutter build windows lib/main_la.dart -v --dart-define version=${{ env.DESTINY_VERSION }}"
+        run: "flutter build windows lib/main_la.dart --dart-define version=${{ env.DESTINY_VERSION }}"
 
       - name: "Copy VC++ redistributables"
         run: |

README.md

@@ -8,7 +8,7 @@
 
 Destiny is a secure file transfer application that allows people to transfer files without needing to reveal their identities to each other or the service provider. All files are end-to-end encrypted, meaning no one except the sender and the receiver can decrypt the contents. Users select a file on their device and then share the generated code with the intended recipient for safe delivery. No sign-up is needed.
 
-Key security features: 
+Key security features:
 
 - **Identity-less**: no need to disclose identity information (such as name, email address, or phone number) to be able to transfer files.
 - **End-to-end encryption**: files are end-to-end encrypted and only the sender and recipient can read them.
@@ -27,7 +27,8 @@ Supported platforms
 - [x] Windows
 - [x] macOS
 - [x] Android (Google Play & F-Droid)
-- [ ] iOS
+- [x] iOS
+
 
 ## Usage
 
@@ -42,12 +43,12 @@ Available on external stores:
 [<img src="assets/images/google-play-store-label.png" height="40" alt="Google Play store">](https://play.google.com/store/apps/details?id=com.leastauthority.destiny)
 [<img src="assets/images/f-droid-store-label.png" height="40" alt="F-Droid  store">](https://f-droid.org/en/packages/com.leastauthority.destiny/)
 
-Alternatively, apps can be downloaded directly from Github release [assets](https://github.com/LeastAuthority/destiny/releases/latest/download/destiny_android.apk) and installed manually.
+Alternatively, apps can be downloaded directly from GitHub release [assets](https://github.com/LeastAuthority/destiny/releases/latest/download/destiny_android.apk)](https://github.com/LeastAuthority/destiny/releases/latest/download/destiny_android.apk) and installed manually.
 
 
 ### Verification
 
-We recommend to [verify every downloaded file](https://github.com/LeastAuthority/destiny/blob/main/doc/releases.md) against the corresponding signature.
+We recommend [verifying every downloaded file](https://github.com/LeastAuthority/destiny/blob/main/doc/releases.md) against the corresponding signature.
 
 ### Please check our [**FAQ**](https://github.com/LeastAuthority/destiny/blob/main/FAQ.md), [**Privacy Policy**](https://github.com/LeastAuthority/destiny/blob/main/PRIVACY-POLICY.md) and [**Terms & Conditions**](https://github.com/LeastAuthority/destiny/blob/main/TERMS.md) to find more information before to using applications.
 
@@ -62,19 +63,20 @@ git clone --recurse-submodules git@github.com:LeastAuthority/destiny.git
 
 ### Dependencies
 
-- Go >= 1.15
+- Go >= 1.19
 - Flutter >= 3.0.0
 - Android SDK for Android builds (>= SDK 24)
 
 ### Unsigned release builds
 
-Builds for magic-wormhole.io:
+Builds for magic-wormhole.io by default:
 
 ```bash
 flutter build linux
 flutter build apk
 flutter build appbundle
 flutter build macos
+flutter build ipa
 ```
 
 Builds for Least Authority servers:
@@ -85,17 +87,22 @@ flutter build linux -t lib/main_la.dart
 
 Builds for local instances:
 
+
 ```bash
 flutter build linux -t lib/main_local.dart
 ```
 
-If flutter is not used for web application, worth to set:
+
+Checkout detail instructions for [building](https://github.com/LeastAuthority/destiny/blob/main/doc/building.md).
+
+If flutter is not used for web application, worth to set to avoid additional files generation and static analysis warnings:
 ```bash
 flutter config --no-enable-web
 ```
 
 Checkout detail instructions how to [sign releases](https://github.com/LeastAuthority/destiny/blob/main/doc/releases.md).
 
+
 ### Starting the wormhole services locally
 
 ```bash
@@ -108,4 +115,9 @@ docker-compose up -d
 so x86 emulators or devices are not supported.
 - MacOS M1 chip build is not supported.
 
+### Other configuration/ notes
+
+- To disable debug label on the app in the emulator, set debugShowCheckedModeBanner: false (two places)
 
+- iOS downloaded files are stored in app/Documents folder, which is displayed in Files App as a dedicated application folder. If Files doesn't display the application folder, try restart phone.
+Note, that if App is deleted, all downloaded files in the same App folder will be deleted too.

doc/building.md

@@ -0,0 +1,67 @@
+# Building details
+
+## iOS building documentation
+
+### *Prerequisit*: 
+* macOS and Xcode is necessary to build iOS or macOS app (Alternatively, may be Xcode cloud could be used).
+* flutter (latest)
+* cmake (latest)
+* cocoapods (latest)
+* workstation (preferrable M1, as it compiles for arm64)
+
+*Note:* iphonesimulator runs on arch: x86_64, iphone on arm64
+
+Check enviroment variables:
+* FLUTTER_ROOT
+* GOROOT
+* Homebrew bin is in PATH
+
+
+Apple Developer account is necessary only if you want to sign and release or you want to install on your own iPhone devices
+
+### *Basic commands:*
+
+Build cleanup: `flutter clean && cd dart_wormhole_william && flutter clean && cd ..`
+
+Additional cleanup: `rm -rf ios/Pods && rm ios/Podfile.loc`
+
+Build ios app debug version with stage servers: `flutter build ios -t lib/main_stage_la.dart --debug`
+
+Build ios app release version with production servers: `flutter build ios -t lib/main_la.dart --debug`
+
+Build and run on simulator or connected iPhone: `flutter run`
+
+Check available devices: `flutter devices`
+
+### *Other notes*
+
+Alternative you can build and run in Xcode, however it not works on every workstation straight away (it execute a little bit differently then flutter commands). Build in Xcode, can give more detail description if something is failing.
+
+If Xcode build fails, first try to build with flutter command: `flutter build ios` and then rebuild in Xcode
+
+For signing: 
+* Add apple developer account in Xcode.
+* Set in Runner->Signing & Capabilities, your team, which you are signing and Enable automatically manage signing
+
+iOS load static libraries, you can find and check if libraries are build and in which arch: `find . -name "*.a" -exec objdump -x {} \;`
+
+Helps to find for some parameters in logs: `rg STRIP_STYLE` or in absolutely all files: `rg -uuu STRIP_STYLE`
+
+Main files to check compilation scripts:
+* dart_wormhole_william/ios/CMakeLists.txt
+* dart_wormhole_william/ios/dart_wormhole_william.podspec
+* dart_wormhole_william/lib/src/CMakeLists.txt
+* dart_wormhole_william/CMakeLists.txt
+
+To check if libraries compiled, included in build and linked properly, run app in iPhone or iPhonesimulator, go to Sender try to load File or Media, code should be generated. Alternatively, you can go to receiver and enter failed code: 1-2-3 and get message: "Something went wrong".
+Note: If you get error: `PlatformException(file_picker_error, Temporary file could not be created`, simulator might have a bug when selecting Media file. Try select any other media file. Also in Destiny application settings, set Document storage: Phone.
+
+### *Troubleshooting*
+
+Sharing some issues, faced during enabling iOS build:
+
+* Failed to lookup symbol 'init_dart_api_dl' iphone simulator - helped setting in Runner->Build Settings->Build Active Architecture Only = Yes
+* Architecture miscompilation and loading arm64 vs amd64 (x86_64). Iphone runs on Arm64, MacBook M1-chip runs on Arm64, MacBook intel runs on amd64, iPhoneSimulator runs on x86_64. We have flutter app, dart_wormhole_william and wormhole_william. All this must match to what you build
+
+
+

doc/releases.md

@@ -23,6 +23,24 @@ flutter build appbundle --build-name=<build_version> --dart-define version=<buil
 Note: Google Play store requires unique or incremental build-number for every upload to store.
 
 
+## iOS bundle upload to App Store
+
+To build for production, use command:
+```bash
+flutter build ipa --build-name=<version> --dart-define version=v<version> -t lib/main_la.dart --release
+```
+
+Prerequisite: Apple Developer account is mandatory
+
+Validate
+```bash
+xcrun altool --validate-app -f build/ios/ipa/Destiny.ipa -t ios -u <username> -p <app passowd>
+```
+Upload
+```bash
+xcrun altool --upload-app -f build/ios/ipa/Destiny.ipa -t ios -u <username> -p <app passowd>
+```
+
 ## MacOS
 
 In order to build signed macos releases, a valid code signing certificate needs to be added to the key chain.

ios/Flutter/AppFrameworkInfo.plist

@@ -2,25 +2,25 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-  <key>CFBundleDevelopmentRegion</key>
-  <string>en</string>
-  <key>CFBundleExecutable</key>
-  <string>App</string>
-  <key>CFBundleIdentifier</key>
-  <string>io.flutter.flutter.app</string>
-  <key>CFBundleInfoDictionaryVersion</key>
-  <string>6.0</string>
-  <key>CFBundleName</key>
-  <string>App</string>
-  <key>CFBundlePackageType</key>
-  <string>FMWK</string>
-  <key>CFBundleShortVersionString</key>
-  <string>1.0</string>
-  <key>CFBundleSignature</key>
-  <string>????</string>
-  <key>CFBundleVersion</key>
-  <string>1.0</string>
-  <key>MinimumOSVersion</key>
-  <string>8.0</string>
+	<key>CFBundleDevelopmentRegion</key>
+	<string>en</string>
+	<key>CFBundleExecutable</key>
+	<string>App</string>
+	<key>CFBundleIdentifier</key>
+	<string>io.flutter.flutter.app</string>
+	<key>CFBundleInfoDictionaryVersion</key>
+	<string>6.0</string>
+	<key>CFBundleName</key>
+	<string>App</string>
+	<key>CFBundlePackageType</key>
+	<string>FMWK</string>
+	<key>CFBundleShortVersionString</key>
+	<string>1.0</string>
+	<key>CFBundleSignature</key>
+	<string>????</string>
+	<key>CFBundleVersion</key>
+	<string>1.0</string>
+	<key>MinimumOSVersion</key>
+	<string>12.0</string>
 </dict>
 </plist>

ios/Flutter/Debug.xcconfig

@@ -1,2 +1,2 @@
-#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
+#include "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
 #include "Generated.xcconfig"

ios/Flutter/Release.xcconfig

@@ -1,2 +1,2 @@
-#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"
+#include "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"
 #include "Generated.xcconfig"

ios/Podfile

@@ -1,5 +1,5 @@
 # Uncomment this line to define a global platform for your project
-# platform :ios, '9.0'
+platform :ios, '12.0'
 
 # CocoaPods analytics sends network stats synchronously affecting flutter build latency.
 ENV['COCOAPODS_DISABLE_STATS'] = 'true'
@@ -25,17 +25,23 @@ end
 
 require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)
 
-flutter_ios_podfile_setup
 
 target 'Runner' do
+  flutter_ios_podfile_setup
+
   use_frameworks!
   use_modular_headers!
 
   flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
-end
 
-post_install do |installer|
-  installer.pods_project.targets.each do |target|
-    flutter_additional_ios_build_settings(target)
+  post_install do |installer|
+    installer.pods_project.build_configurations.each do |config|
+      config.build_settings["STRIP_STYLE"] = "non-global"
+      config.build_settings['IOS_DEPLOYMENT_TARGET'] = '12.0'
+    end
+
+    installer.pods_project.targets.each do |target|
+      flutter_additional_ios_build_settings(target)
+    end
   end
 end