Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling for code generation and update client #179

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Fix error handling for code generation and update client #179

merged 2 commits into from
Sep 26, 2022

Conversation

ewanas
Copy link
Contributor

@ewanas ewanas commented Sep 26, 2022

Code Review Checklist

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@ewanas ewanas merged commit 87b884e into main Sep 26, 2022
@ewanas ewanas deleted the error-handling-fixes branch September 26, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donpui donpui donpui approved these changes

@shareef-dweikat shareef-dweikat Awaiting requested review from shareef-dweikat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewanas @donpui