Info screen desktop #170
Merged
Info screen desktop #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donpui
reviewed
Sep 19, 2022
lib/views/desktop/settings.dart
Outdated
| ), | ||
| DTButtonWithBackground( | ||
| onPressed: selectSaveDestination, | ||
| title: SELECT_A_FOLDER, | ||
| width: 150.0, | ||
| disabled: false, | ||
| ) | ||
| ), | ||
| Container( |
There was a problem hiding this comment.
Hard to read and understand containers part, but not sure if is possible to group components/box in better code visibility.
meejah
reviewed
Sep 19, 2022
lib/views/desktop/settings.dart
Outdated
| @@ -5,9 +5,12 @@ import 'package:destiny/views/desktop/widgets/DTButtonWithBackground.dart'; | |||
| import 'package:destiny/views/desktop/widgets/custom-app-bar.dart'; | |||
| import 'package:destiny/views/shared/settings.dart'; | |||
| import 'package:destiny/views/widgets/Heading.dart'; | |||
| import 'package:destiny/views/widgets/Linkes.dart'; | |||
There was a problem hiding this comment.
minor, but this should probably be "Links.dart" assuming English..
shareef-dweikat
force-pushed
the
info-screen-desktop
branch
from
8ece36d
to
cdb5318
Compare
shareef-dweikat
force-pushed
the
info-screen-desktop
branch
from
cdb5318
to
9541c2d
Compare
shareef-dweikat
force-pushed
the
info-screen-desktop
branch
from
9cd67c6
to
26bed04
Compare
donpui
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Review Checklist