Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public keys and source tarball creation script #166

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Add public keys and source tarball creation script #166

merged 1 commit into from
Sep 13, 2022

Conversation

ewanas
Copy link
Contributor

@ewanas ewanas commented Sep 13, 2022

OP#1144


Code Review Checklist

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

Copy link
Collaborator

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; see inline suggestion.

Also might be worth putting the signing command in, too (maybe one for each of you) to copy-paste at least.

@meejah
Copy link
Collaborator

meejah commented Sep 13, 2022

hmm, not sure what happened to the inline comment .. was essentially just "maybe git archive works for the tarball" but per other discussion, that doesn't cover submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants