Enable iOS plugin #40
Conversation
| @@ -142,11 +143,19 @@ class Config { | |||
| class NativeClient { | |||
| late final DynamicLibrary _wormholeWilliamLib; | |||
| late final DynamicLibrary _asyncCallbackLib; | |||
|
|
|||
| late final Config config; | |||
|
|
|||
| NativeClient({Config? config}) { | |||
There was a problem hiding this comment.
@ewanas can we make error handling here in case we fail to load library? For example, if I run iOS app on amd64 arch and if fails to load static libraries, receive or sender is just as waiting.. Probably we should throw error and display something to user as technical error.
There was a problem hiding this comment.
Because we rely on executable() as the source of symbols here, the case of "could not find the library" isn't possible. Right now symbols are looked up when a client function needs them. Maybe the constructor for NativeClient can lookup or check if all needed symbols are there beforehand otherwise fail with an error
There was a problem hiding this comment.
From other hand.. this is more a check for build not for running. I am thinking can be there any cases, when libraries stop loading up during installation or launching. For example tries to load ios app retrieved from apple store and run in ios simulator..
|
Also updated submodule to latest w-w version as there was fix for hints. |
Add iOS dart plugin with static libraries compilation
Related with Destiny issue 196
Code Review Checklist (to be filled out by reviewer)