Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEAR review #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

NEAR review #1

wants to merge 4 commits into from

Conversation

amgando
Copy link

@amgando amgando commented Jul 7, 2021

  1. refactor string concatenation in the generate function
  2. refactor calls to Context.sender to save on gas
  3. refactor logging messages into a single logMessage function
  4. refactor to add guard clause before calling designs.getSome()
  5. refactor Design class by adding a static generate function
  6. refactor two Persistent* classes into one
  7. surfaced pagination params to viewDesigns contract method

3. refactor logging messages into a single logMessage function
4. refactor to add guard clause before calling designs.getSome()
5. refactor Design class by adding a static generate function
6. refactor two Persistent* classes into one
7. surfaced pagination params to viewDesigns contract method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant