Refactor L.Path _update and _project into L.Renderer so that no event handling is needed #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handling is needed
DiogoMCampos
pushed a commit
to DiogoMCampos/Leaflet
that referenced
this pull request
Dec 18, 2016
… handling is needed (Leaflet#5054) * Refactor L.Path _update and _project into L.Renderer so that no event handling is needed * Refactor away L.Path's _update event logic
DiogoMCampos
pushed a commit
to DiogoMCampos/Leaflet
that referenced
this pull request
Dec 18, 2016
… handling is needed (Leaflet#5054) * Refactor L.Path _update and _project into L.Renderer so that no event handling is needed * Refactor away L.Path's _update event logic
IvanSanchez
added a commit
that referenced
this pull request
Dec 23, 2016
mourner
pushed a commit
that referenced
this pull request
Dec 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative approach to #5044 - if the problem is that every path hooks up two events, then simply remove the event logic altogether.