Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional tabs integration #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bUxEE
Copy link

@bUxEE bUxEE commented Jun 12, 2018

Added integration for "show_on_cb" option already present in CMB2 field options to enable conditional tabs.

@bUxEE bUxEE changed the title Update cmb2-tabs.class.php Conditional tabs integration Jun 12, 2018
@pgroot91
Copy link

pgroot91 commented Apr 23, 2020

I have tested the branch and have some problems with the implementation.

  1. You need to have the "show_on_cb" specified on your tabs or you will get the following notices.

Notice: Undefined index: show_on_cb in C:\xampp\htdocs\dev1\wp-content\plugins\my-plugin\includes\cmb2-tabs\inc\cmb2-tabs.class.php on line 67
Notice: Undefined index: show_on_cb in C:\xampp\htdocs\dev1\wp-content\plugins\my-plugin\includes\cmb2-tabs\inc\cmb2-tabs.class.php on line 79

  1. My bad! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants