New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip map vote if only one map is configured #33

Merged

MD-V merged 6 commits into main from feature/fix_issue_32

Nov 15, 2023

Contributor

MD-V commented Nov 15, 2023

Fixes #32


          Skip map vote if only one map is configured

d0cfe0f

MD-V requested a review from TheR00st3r

November 15, 2023 12:57


          Fix OneMapConfigured check

a5bfa61

TheR00st3r reviewed

View reviewed changes

PugSharp.Match/Match.cs Outdated

                           .OnEntry(StartWarmup)
                           .OnEntry(SetAllPlayersNotReady)
                           .OnEntry(StartReadyReminder)
                           .OnExit(StopReadyReminder);
+                      _MatchStateMachine.Configure(MatchState.PreMapVote)
+                         .PermitDynamicIf(MatchCommand.MapListCheckCompleted, () => OneMapConfigured() ? MatchState.TeamVote : MatchState.MapVote)

Member

TheR00st3r Nov 15, 2023

I think it would be better to do the check and state transition in the state WaitingForPlayersConnectedReady and also split the dynamic permit into two transitions

MD-V added 4 commits

November 15, 2023 20:14


          Integrate into MapVote state

ba15782


          Add unit test

5dd41e6


          Merge branch 'main' into feature/fix_issue_32

db9c2e1


          Fix build error

2643bc2

sonarcloud bot commented Nov 15, 2023

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

73.1% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

MD-V merged commit 3c9381e into main

6 of 7 checks passed

MD-V deleted the feature/fix_issue_32 branch

November 15, 2023 19:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet