Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add thevace and neruxvace adjustments #646

Merged
merged 11 commits into from
Sep 19, 2023
Merged

Conversation

Eptiiix
Copy link
Contributor

@Eptiiix Eptiiix commented Jul 31, 2023

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Updated the manifest of neruxvace as we are no longer part of them
Added thevace as new directory

@github-actions
Copy link

Just as an information:
Your server thevace.net could be offline.
In general, we only accept pull requests from servers, that are online. Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

If your server is currently online, then our api returned a wrong status, we will have a look at it :)

Reference: API URL (https://api.mcsrvstat.us/2/thevace.net)

Copy link
Member

@JakobBruening JakobBruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please compress image(s)
  • Please fix formatting (space after key) in json file

minecraft_servers/thevace/manifest.json Outdated Show resolved Hide resolved
minecraft_servers/thevace/manifest.json Outdated Show resolved Hide resolved
minecraft_servers/thevace/manifest.json Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Just as an information:
Your server thevace.net could be offline.
In general, we only accept pull requests from servers, that are online. Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

If your server is currently online, then our api returned a wrong status, we will have a look at it :)

Reference: API URL (https://api.mcsrvstat.us/2/thevace.net)

2 similar comments
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Just as an information:
Your server thevace.net could be offline.
In general, we only accept pull requests from servers, that are online. Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

If your server is currently online, then our api returned a wrong status, we will have a look at it :)

Reference: API URL (https://api.mcsrvstat.us/2/thevace.net)

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Just as an information:
Your server thevace.net could be offline.
In general, we only accept pull requests from servers, that are online. Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

If your server is currently online, then our api returned a wrong status, we will have a look at it :)

Reference: API URL (https://api.mcsrvstat.us/2/thevace.net)

Copy link
Member

@JakobBruening JakobBruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, file size is an issue. Please compress or resize (2,5MB is way too large, 1.12 is also optimizable).

@JakobBruening JakobBruening merged commit aaa4ef5 into LabyMod:master Sep 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants