Skip to content
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.

GenerateGUID shim should more obviously be constant or generate actual unique IDs #153

Open
Kampfkarren opened this issue Nov 16, 2018 · 2 comments

Comments

@Kampfkarren
Copy link
Contributor

GenerateGUID doesn't actually generate a GUID--it gives a constant one. This is fine, but it's deceptive and looks random. I don't see a problem in changing it to something to where developers can easily tell its a shim (like 000000-...)

return "04AEBFEA-87FC-480F-A98B-E5E221007A90"

@ZoteTheMighty
Copy link
Contributor

Funny, I just bumped into this myself.

When I added this, I didn't think too much about it, but you're absolutely right about it being misleading. I think the best solution would be to actually generate something unique so that anything that depends on generated ids will actually get different values.

@Kampfkarren
Copy link
Contributor Author

Kampfkarren commented Nov 16, 2018

+1 for "actually generate something unique so that anything that depends on generated ids will actually get different values"

Probably doesn't have to be anything complicated, a counter ticking up would probably work.

@Kampfkarren Kampfkarren changed the title GenerateGUID shim should more obviously be constant GenerateGUID shim should more obviously be constant or generate actual unique IDs Nov 16, 2018
Kampfkarren added a commit to Kampfkarren/lemur that referenced this issue Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants