Add swap method for array class #152
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adayton1
commented
Jun 7, 2024
adayton1
commented
- Adds swap method for array class and external swap method for two arrays
- Adds test case for swap
trws
reviewed
Jun 7, 2024
MrBurmark
previously approved these changes
Jun 7, 2024
trws
approved these changes
Jun 13, 2024
MrBurmark
reviewed
Jun 17, 2024
| CAMP_HOST_DEVICE constexpr | ||
| typename std::enable_if<std::is_nothrow_move_constructible<T>::value && | ||
| std::is_nothrow_move_assignable<T>::value>::type | ||
| swap(array& a) noexcept(std::is_nothrow_swappable<T>::value) { |
There was a problem hiding this comment.
is_nothrow_swappable is C++17
There was a problem hiding this comment.
Right you are. Converting back to a draft until I have time to look at this again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.