Export BLT TPL targets #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trws can you take a look at this when you get a chance? Let me know if you have any questions. |
|
Looks like it's purely additive, does this take care of our exported targets issue, or at least part of it? |
|
Yup, I have been testing this branch in the Umpire PR. With these changes, a camp built as part of Umpire will work in a non-BLT CMake project. |
|
That's absolutely fantastic. Approved! Want an RC release or similar for this? |
trws
approved these changes
May 24, 2022
|
I can work off main for now - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.