delete setFromArray method in vectors classes

LCluber · Aug 29, 2020 · c62e71c · c62e71c
1 parent 104873d
commit c62e71c
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 63 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+Version 2.1.0 (August 29th 2020)
+-----------------------------
+ * delete setFromArray() method in Vector2 and Vector3 classes
+
 Version 2.0.1 (May 13th 2020)
 -----------------------------
  * fix lookAtRH() method in Matrix4x3 class

diff --git a/dist/type6.d.ts b/dist/type6.d.ts
@@ -215,7 +215,6 @@ export declare class Vector2 {
     constructor(x?: number, y?: number);
     isOrigin(): boolean;
     isPositive(): boolean;
-    setFromArray(array: number[], offset?: number): Vector2;
     toArray(): number[];
     toString(): string;
     set(x: number, y: number): Vector2;
@@ -255,17 +254,13 @@ export declare class Vector2 {
     lerp(min: Vector2, max: Vector2, amount: number): Vector2;
     dotProduct(v: Vector2): number;
 }
-export interface Vector3 {
-    [key: string]: any;
-}
 export declare class Vector3 {
     x: number;
     y: number;
     z: number;
     constructor(x?: number, y?: number, z?: number);
     isOrigin(): boolean;
     isPositive(): boolean;
-    setFromArray(array: number[], offset?: number): Vector3;
     toArray(): number[];
     toString(): string;
     set(x: number, y: number, z: number): Vector3;

diff --git a/dist/type6.iife.js b/dist/type6.iife.js
@@ -309,14 +309,6 @@ var Type6 = (function (exports) {
         Vector2.prototype.isPositive = function () {
             return this.x >= 0 && this.y >= 0 ? true : false;
         };
-        Vector2.prototype.setFromArray = function (array, offset) {
-            if (offset === undefined) {
-                offset = 0;
-            }
-            this.x = array[offset];
-            this.y = array[offset + 1];
-            return this;
-        };
         Vector2.prototype.toArray = function () {
             return [this.x, this.y];
         };
@@ -692,15 +684,6 @@ var Type6 = (function (exports) {
         Vector3.prototype.isPositive = function () {
             return this.x >= 0 && this.y >= 0 && this.z >= 0 ? true : false;
         };
-        Vector3.prototype.setFromArray = function (array, offset) {
-            if (offset === undefined) {
-                offset = 0;
-            }
-            this.x = array[offset];
-            this.y = array[offset + 1];
-            this.z = array[offset + 2];
-            return this;
-        };
         Vector3.prototype.toArray = function () {
             return [this.x, this.y, this.z];
         };

diff --git a/dist/type6.iife.min.js b/dist/type6.iife.min.js
diff --git a/dist/type6.js b/dist/type6.js
@@ -334,14 +334,6 @@ class Vector2 {
     isPositive() {
         return (this.x >= 0 && this.y >= 0) ? true : false;
     }
-    setFromArray(array, offset) {
-        if (offset === undefined) {
-            offset = 0;
-        }
-        this.x = array[offset];
-        this.y = array[offset + 1];
-        return this;
-    }
     toArray() {
         return [this.x, this.y];
     }
@@ -702,15 +694,6 @@ class Vector3 {
     isPositive() {
         return (this.x >= 0 && this.y >= 0 && this.z >= 0) ? true : false;
     }
-    setFromArray(array, offset) {
-        if (offset === undefined) {
-            offset = 0;
-        }
-        this.x = array[offset];
-        this.y = array[offset + 1];
-        this.z = array[offset + 2];
-        return this;
-    }
     toArray() {
         return [this.x, this.y, this.z];
     }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lcluber/type6js",
-  "version": "2.0.1",
+  "version": "2.1.0",
   "description": "Mathematics library for Javascript",
   "keywords": [
     "maths",

diff --git a/src/vectors/vector2.ts b/src/vectors/vector2.ts
@@ -26,15 +26,6 @@ export class Vector2 {
     return ( this.x >= 0 && this.y >= 0 ) ? true : false;
   }
 
-  public setFromArray( array: number[], offset?: number ): Vector2 {
-    if ( offset === undefined ){
-      offset = 0;
-    }
-    this.x = array[ offset ];
-    this.y = array[ offset + 1 ];
-    return this;
-  }
-
   public toArray(): number[] {
     return [ this.x, this.y ];
   }

diff --git a/src/vectors/vector3.ts b/src/vectors/vector3.ts
@@ -1,7 +1,7 @@
 
-export interface Vector3 {
-  [key: string]: any;
-}
+// export interface Vector3 {
+//   [key: string]: any;
+// }
 
 export class Vector3 {
   public x: number;
@@ -23,16 +23,6 @@ export class Vector3 {
     return ( this.x >= 0 && this.y >= 0 && this.z >= 0) ? true : false;
   }
 
-  public setFromArray( array: number[], offset?: number ): Vector3 {
-    if ( offset === undefined ){
-      offset = 0;
-    }
-    this.x = array[ offset ];
-    this.y = array[ offset + 1 ];
-    this.z = array[ offset + 2 ];
-    return this;
-  }
-
   public toArray(): number[] {
     return [ this.x, this.y, this.z ];
   }