Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DART end of mission PDS liens #626

Open
19 of 20 tasks
talister opened this issue Sep 19, 2023 · 0 comments
Open
19 of 20 tasks

Fix DART end of mission PDS liens #626

talister opened this issue Sep 19, 2023 · 0 comments
Assignees
@talister
Labels
PDS Planetary Data System-related issues

Comments

@talister
Copy link
Member

talister commented Sep 19, 2023 •
edited
Loading

Major issues:

  • 1. Missing calibration files from the exported directories
  • 2. Incorrect display settings for the 4 amp raw Sinistro data
  • 3. Incorrect celestial north clock angle

Minor issues:

  • data_lcogt_flical overview.txt: Add more overview on the dataset and instrument.
  • data_lcogt_flical overview.txt: Remove Sinistro-specific language. Add details about WCSERR and bad fits
  • data_lcogt_fliddp overview.txt: Provide more details on aperture sizes
  • data_lcogtcal overview.txt: Add more info about time span of Sinistro data used
  • data_lcogtddp overview.txt: Add info about conversion of photometry to PS r mags. Add reference to the data_lcogtraw overview.txt for filter usage details
  • Eliminate duplicate telescopes in <Observing_System>

And then there were more... (from PDS Engineering node)

Larger meta-lien:

  • Move master calibration files into their own directory under data_lcogt_{prefix}cal

Specific numbered liens:

  • data_lcogt_flical overview.txt still has references to readout window which don't apply
  • Need more info on which frames are sidereally tracked or not
  • Add info on flux radius to DDP XML labels
  • Observing_System context objects for Host and Telescope should have actual descriptions
  • Should each Telescope LCOGT 1m-NN be a unique context object entry or combined into a "Telescopes" entry as is with the ingested context object? If the former, can they all still point to the same context LID?
  • The data files corresponding data_lcogt* and data_lcogt_fli* have the same <title> and . Should include mention of the Imager (Sinistro vs FLI) to make them unique.
  • Please update the <title> and for document_lcogt <Identification_Area>, to better conform to what the data collections share. Currently the description is almost meaningless, and the title should not really have commas.
  • document_lcogt/collection_lcogtdoc.xml --> I would not expect there to be a Target_Identification section for the document collection. Please remove.
  • file: 'data_lcogt_fliraw/collection_data_lcogt_fliraw.csv'. The first LID is wrong. It is missing the 'w' in overview and should be urn:nasa:pds:dart_teleobs:data_lcogt_fliraw:collection_data_lcogt_fliraw_overview::1.0
  • file: 'document_lcogt/collection_lcogtdoc.xml', --> the should be corrected to 3 from 2.
@talister talister added the PDS Planetary Data System-related issues label Sep 19, 2023
@talister talister self-assigned this Sep 19, 2023
talister added a commit that referenced this issue Sep 19, 2023
@talister
Need additional wildcards on the end for find_fits_files() to find ca…
770cca5 
…libration files (broke in 70ec6cd when fixing pickup of DIA products... <sigh>). Partfix for 1. of Issue #626.
talister added a commit that referenced this issue Sep 20, 2023
@talister
Update docs for FLI dataset to address some of the liens in Issue #626
d059d72
talister added a commit that referenced this issue Sep 22, 2023
@talister
Update to fix Display_Direction major lien (Issue #626):
1b7abb7 
Move Display_Direction generating code back into per-amp/extension loop.
Add ability to pass whether directions are left-to-right/bottom-to-top
or the inverse into create_display_direction().
Define a directions mapping dictionary for LCOGT data which has the
correct set of direction flips for raw (e00) data.
Update example whitespace to match generated code.
talister added a commit that referenced this issue Sep 22, 2023
@talister
Update overview docs to address liens (Issue #626)
48721ac
talister added a commit that referenced this issue Sep 23, 2023
@talister
Eliminate duplicate telescopes in <Observing_System> part of <Context…
3084519 
…_Area> (needs updated unit test; Issue #626)
talister added a commit that referenced this issue Oct 4, 2023
@talister
Improve description of the flux_radius in DDP XML files. (Addresses I…
c03ab0a 
…tem #3 of new liens list in Issue #626)
talister added a commit that referenced this issue Oct 4, 2023
@talister
Remove Target_Identification for document collection XML (Addresses #8 …
488192a 
…of liens for Issue #626)
talister added a commit that referenced this issue Oct 4, 2023
@talister
Fix documentation for the data_lcogt_flical overview.txt file to fix …
3e2c72b 
…liens #1 and #2 for Issue #626

Add more details about the non-sidereal tracking and the apparent sidereal tracking in the very short exposures.
Remove details about readout window that don't apply to FLI cameras and add info about the readout speed being lowercased.
talister added a commit that referenced this issue Oct 5, 2023
@talister
Major changes to the Observing_System sections and Identification_Are…
6bd3b48 
…a to address liens 4-6 (Issue #626)

Add instrument class (Sinistro, FLI) into <title>s
Remove non-description from the Host <Observing_System_Component>
Add better description to the Telescope <Observing_System_Component>.
Remove per-telescope <Observing_System_Component> replacing with generic 1m
Change '<foo> Camera' references to '<foo> Imager'
Add reference to urn:nasa:pds:dart_teleobs:document_lcogt:<camera>_description in description.
Add example FLI headers and tests using them.
talister added a commit that referenced this issue Oct 5, 2023
@talister
Fix documentation_lcogt liens 7 and 10 for Issue #626
18986f7 
Update titles and descriptions to match other DART telescopic datasets. Add Internal_Reference for Host, Telescope and Instruments and reference list. Correct file sizes.
talister added a commit that referenced this issue Oct 6, 2023
@talister
Fix meta-lien #0 for moving calibration files into separate directory…
d3f8380 
… (Issue #626). Fix issue with ddp collection generation for FLI data.

Transfer master calib files to the new paths['calib'] calibration directory and generate labels for them once done with the loop over blocks.
Fix issue with ddp collection generation for FLI data by pointing at the proper data_lcogt{prefix}cal if we have a block_dir that ends in either 'data_lcogt_fliddp' or 'data_lcogtddp' (the original)
carrholt pushed a commit that referenced this issue Dec 7, 2023
@talister @carrholt
Eliminate duplicate telescopes in <Observing_System> part of <Context…
8a4411e 
…_Area> (needs updated unit test; Issue #626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talister talister

Labels
PDS Planetary Data System-related issues
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

issue-626_PDS_liens LCOGT/neoexchange
1 participant
@talister