Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shell escape #36

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Fix shell escape #36

merged 2 commits into from
Oct 4, 2022

Conversation

atesca09
Copy link

@atesca09 atesca09 commented Oct 4, 2022

Fixes #35

Split the command line args to a list, so it works with shell=False.
remove shell=false parameter as it overwrites the default value with the same value

L2jLiga
L2jLiga approved these changes Oct 4, 2022
View reviewed changes
Copy link
Owner

@L2jLiga L2jLiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@L2jLiga L2jLiga merged commit 03d1e78 into L2jLiga:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L2jLiga L2jLiga L2jLiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabling shell in subprocess call requires arguments as list
3 participants
@atesca09 @L2jLiga @nmtschwarz