api: Use initial style when replacement-rendering a hover event #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezz
approved these changes
Dec 14, 2021
kashike
approved these changes
Dec 14, 2021
This matters if the component is entirely replaced due to an exact match
|
how does this handle cases where both the original component and the replacement result have different hover events? I think the most sensible behaviour would be to use the replacement result's hover event and ignore the incoming one - could you add a test to ensure that's what happens? |
|
Which would be the "incoming" one here? |
|
the one from the pre-replacement component, sorry |
|
nog sure I communicated thix properly in my initial comment - but I was thinking more specifically of a case where both hover events had content that matched the replacement pattern |
zml2008
approved these changes
Dec 14, 2021
This was referenced Feb 28, 2022
This was referenced Feb 28, 2022
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 14, 2022
This was referenced Apr 13, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #638
This matters if the component is entirely replaced due to an exact match (whereas a non-exact match creates an empty parent with no style)
I'm not 100% sure this won't cause more issues in the future, but i tried to follow how children are implemented with oldChildren