Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform-bukkit: fix ViaVersion softDepend occurring too late #80

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

TehBrian
Copy link

No description provided.

@zml2008 zml2008 added this to the 4.0.2 milestone Jan 26, 2022
@zml2008 zml2008 self-assigned this Jan 26, 2022
@zml2008 zml2008 added the type: bug Something isn't working label Jan 26, 2022
@kezz
Copy link
Member

kezz commented Jan 26, 2022

Would it not be easier to just lazily initialise the empty audience? It's the creation of the empty audience that is causing this issue after all.

@TehBrian
Copy link
Author

Chucking softDepend in BukkitAudiences.Builder would fix the root problem (creating BukkitAudiencesImpl before calling softDepend) rather than the symptom, but both fixes would work. Let me know what fix to implement and I'll update the pr.

@kezz
Copy link
Member

kezz commented Feb 3, 2022

@TehBrian would you mind making both changes? So, moving the soft depend method and making the empty audience lazily initialised? Sorry for the annoyance :p

@zml2008 zml2008 merged commit c51f500 into KyoriPowered:master Feb 4, 2022
This was referenced Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants