-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Fix 1d consolidation test (#12030) #12041
Conversation
…st_benchmark_set_1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...ions/GeoMechanicsApplication/tests/1D-Consolidation_all_stages/ProjectParameters_stage2.json
Outdated
Show resolved
Hide resolved
This test consists of 78 6-noded elements (using the SmallStrainUPwDiffOrderElement2D6N class) of b x h = 0.1 x 1.0 meter. A | ||
schematic representation can be found in the figure below: | ||
|
||
![MeshStructure](MeshStructure.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The figure is really good. Thanks for putting it with the documentation. Maybe just a suggestion:
Do you think it makes sense if we also show the amount of the load on top of the load? And maybe also the dimension of the soil column on the figure? I think this would help to get most of the information needed by just looking at the figure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried to change according to the comments. Please check again.
applications/GeoMechanicsApplication/tests/1D-Consolidation_all_stages/README.md
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/1D-Consolidation_all_stages/README.md
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/1D-Consolidation_all_stages/README.md
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/1D-Consolidation_all_stages/README.md
Outdated
Show resolved
Hide resolved
...ions/GeoMechanicsApplication/tests/1D-Consolidation_all_stages/ProjectParameters_stage2.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for thoroughly cleaning up, documenting and reviving this test. It is much more readable now and it is no longer skipped during automatic test runs. Well done!
📝 Description
Enabled 1D consolidation test.
Simplified stage setup ( only 1 .mdpa file and 1 material file remain )
Stages end exactly at the proposed dimensionless times.
README.md file added together with picture of the test geometry and boundary conditions.