Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard-library logging for verbose logging #28

Merged
merged 7 commits into from
Oct 5, 2024

Conversation

EpicWink
Copy link
Contributor

Instead of print - allows for more configurability by the user

@bwoodsend
Copy link
Collaborator

Hmm, I'm rather reluctant to make logging part of pyfqmr's import footprint/startup time impact. I'd rather just say if you want something other than print then set verbose to false and do it yourself. (Well, really I wish the verbose option didn't exist but hey ho...)

@EpicWink
Copy link
Contributor Author

EpicWink commented Sep 26, 2024

Oh, in that case the import can be moved to inside if verbose: (I have to test whether Cython supports this).

@bwoodsend bwoodsend merged commit 6de5286 into Kramer84:master Oct 5, 2024
18 checks passed
@bwoodsend
Copy link
Collaborator

Thanks for these changes @EpicWink. Sorry for the rather slow/bikesheddy/not really with it/abrasive reviews.

I'll try and hit the release button in a few days (hopefully after #34 goes in).

@EpicWink EpicWink deleted the logging branch October 8, 2024 01:26
@EpicWink
Copy link
Contributor Author

EpicWink commented Oct 8, 2024

No worries, all valid concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants