Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MANIFEST.in to include demo and docs in PyPi tarballs, fixes #425 #428

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbraz
Copy link

@sbraz sbraz commented Jun 17, 2018

Hi,
Distributions often rely on PyPI tarballs to build docs. The current PyPI tarballs do not contain them. The sdist file that I obtain with the MANIFEST.in file also contains COPYING, so this fixes #425.

I tried to remove a few files that aren't needed like the old doc tarball, feel free to change the MANIFEST.in file.

@paradoxxxzero
Copy link
Member

I'm sorry but why would you want to have the docs in the PyPi package? I see no use case and it'll surely increase the package size.

@@ -0,0 +1,3 @@
exclude .* pygal_doc_old.tar.xz tox.ini
graft demo docs tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graft?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbraz
Copy link
Author

sbraz commented Jun 18, 2018

We at Gentoo rely on PyPI tarballs to build docs, I am pretty sure that this is also the case for Debian maintainers.
The compressed tarball is only a little over a MiB, that's less than a floppy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License file in pypi archive
2 participants