Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(entities-certificates): support sni field in form [KM-199] #1458

Merged
merged 2 commits into from
Aug 1, 2024
Merged

feat(entities-certificates): support sni field in form [KM-199] #1458

merged 2 commits into from
Aug 1, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Jun 19, 2024 •
edited
Loading

Summary

Adding an snis field in certificate form.

KM-199

Resources

@Leopoldthecoder Leopoldthecoder force-pushed the feat/certificate-form-sni-field branch from f1db3ee to 1a35a83 Compare July 17, 2024 08:44
@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review August 1, 2024 05:32
@Leopoldthecoder Leopoldthecoder requested review from a team as code owners August 1, 2024 05:32
sumimakito
sumimakito approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested with the latest Gateway image and LGTM

@Leopoldthecoder Leopoldthecoder merged commit 90d4ba0 into main Aug 1, 2024
7 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/certificate-form-sni-field branch August 1, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumimakito sumimakito sumimakito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @sumimakito