fix(*): schema desc transformation in plugin forms #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumimakito
requested review from
LukeSwierlik,
QueaT-kong and
a team
as code owners
sumimakito
force-pushed
the
chore/KAG-3347-plugin-desc
branch
from
f9f6315
to
1f67076
Compare
sumimakito
force-pushed
the
chore/KAG-3347-plugin-desc
branch
from
1f67076
to
76961f0
Compare
|
Note: although it seems that we are not using |
kaiarrowood
reviewed
Dec 20, 2023
kaiarrowood
approved these changes
Dec 20, 2023
adamdehaven
requested changes
Dec 20, 2023
There was a problem hiding this comment.
@sumimakito, @hl782 would like to test this before merge. I'm pulling the package into this khcp-ui PR; and blocking merge until he signs off (no actual issues).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the plugin form use descriptions from backend schemas when descriptions are not defined in frontend schemas. It also fixes some current issues with tooltips.
Tooltips for schema fields
Example:
request-validatorTooltips for nested fields
Example:
rate-limiting-advancedMissing tooltips
Example:
jwt(some descriptions are missing from Konnect API but available in the Gateway Admin API)Outdated tooltips
Example:
kafka-upstreamKAG-3347