This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(client) ensure validTtl
override does not interfere with TTL of
#134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entries from hosts files
See: Kong/kong#7444 for bug report
The
validTtl
setting forcibly overwrites TTL inside thecacheinsert
function. However, this inadvertently overrides the TTL of hosts file
entries as well so that they may expire prematurely, causing resolving
failures later.
This PR changes so that
validTtl
will only be enabled after allentries from hosts file are inserted.