Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fix(timers) reduce timers used #112

Merged
merged 3 commits into from
Jan 4, 2021
Merged

fix(timers) reduce timers used #112

merged 3 commits into from
Jan 4, 2021

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Dec 31, 2020

This implementation of timer reduction uses a binary heap to sort the values up for renewal, so the update mechanism does not iterate over all targets in all balancers, but only checks the ones to renew. So this is more efficient.

@Tieske Tieske requested a review from locao December 31, 2020 08:01
Copy link
Contributor

@locao locao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I just marked a few commented code that should be removed.

spec/balancer/generic_spec.lua Outdated Show resolved Hide resolved
spec/balancer/generic_spec.lua Outdated Show resolved Hide resolved
src/resty/dns/balancer/base.lua Show resolved Hide resolved
src/resty/dns/balancer/base.lua Show resolved Hide resolved
Tieske and others added 2 commits January 4, 2021 15:51
Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants