Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Remove table.move for arm64 compatiblity #93

Closed
hbagdi opened this issue May 14, 2020 · 2 comments · Fixed by #95
Closed

Remove table.move for arm64 compatiblity #93

hbagdi opened this issue May 14, 2020 · 2 comments · Fixed by #95

Comments

@hbagdi
Copy link
Member

hbagdi commented May 14, 2020

Kong/kong#5869

@Tieske
Copy link
Member

Tieske commented May 15, 2020

not sure this is the right approach, what are the options to fix LuaJIT @javierguerragiraldez ? wouldn't that be quicker?

@javierguerragiraldez
Copy link

The fix to LuaJIT (LuaJIT/LuaJIT#583) is simple and looks safe but I'd like some comment from anybody familiar with the assembly interpreter. Also, table.move is one of those functions that are really not needed. Written in Lua would be just as fast. Finally, it's not used anywhere else.

(Btw, shouldn't it be size = size - count just a few lines above?)

Tieske added a commit that referenced this issue May 18, 2020
@Tieske Tieske mentioned this issue May 18, 2020
Tieske added a commit that referenced this issue May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants