Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Do not write multi-line error logs entries #52

Closed
p0pr0ck5 opened this issue Aug 2, 2018 · 0 comments · Fixed by #55
Closed

Do not write multi-line error logs entries #52

p0pr0ck5 opened this issue Aug 2, 2018 · 0 comments · Fixed by #55
Assignees
@Tieske

Comments

@p0pr0ck5
Copy link

p0pr0ck5 commented Aug 2, 2018

We see entries like this

2018/08/02 19:23:46 [error] 2669#0: *169201 [lua] balancer.lua:783: execute(): [dns] dns server error: 3 name error. Tried: (short)dne:(na) - cache-miss
dne.service.kong-aws-us-west-1:1 - cache-miss/scheduled/querying/dns server error: 3 name error
dne.node.kong-aws-us-west-1:1 - cache-miss/scheduled/querying/dns server error: 3 name error
dne:1 - cache-miss/scheduled/querying/dns server error: 3 name error
dne.service.kong-aws-us-west-1:5 - cache-miss/scheduled/querying/dns server error: 3 name error
dne.node.kong-aws-us-west-1:5 - cache-miss/scheduled/querying/dns client error: 101 empty record received
dne:5 - cache-miss/scheduled/querying/dns server error: 3 name error
dne.service.kong-aws-us-west-1:33 - cache-miss/scheduled/querying/dns server error: 3 name error
dne.node.kong-aws-us-west-1:33 - cache-miss/scheduled/querying/dns client error: 101 empty record received
dne:33 - cache-miss/scheduled/querying/dns server error: 3 name error
, client: 98.173.7.34, server: kong, request: "GET / HTTP/1.1", host: "poprocks.kong-cloud.com"

This is impossible to parse correct. It would be great if the __tostring metamethod didn't separate these by newline:

lua-resty-dns-client/src/resty/dns/client.lua

Line 320 in 13c7039

l[i]="\n"

@Tieske Tieske self-assigned this Aug 3, 2018
Tieske added a commit that referenced this issue Aug 23, 2018
@Tieske
fix(logging) encode try-list as json and no longer use new-line
154b7fd 
New-line characters in the logging are impossible to parse
correctly so should be prevented.

fixes #52
Tieske added a commit that referenced this issue Aug 23, 2018
@Tieske
fix(logging) encode try-list as json and no longer use new-line
24cb8bf 
New-line characters in the logging are impossible to parse
correctly so should be prevented.

fixes #52
Tieske added a commit that referenced this issue Aug 23, 2018
@Tieske
fix(logging) encode try-list as json and no longer use new-line
75a7c0c 
New-line characters in the logging are impossible to parse
correctly so should be prevented.

fixes #52
@Tieske Tieske mentioned this issue Aug 23, 2018
Merged
Tieske added a commit that referenced this issue Aug 25, 2018
@Tieske
fix(logging) encode try-list as json and no longer use new-line
d131348 
New-line characters in the logging are impossible to parse
correctly so should be prevented.

fixes #52
Tieske added a commit that referenced this issue Aug 27, 2018
@Tieske
fix(logging) encode try-list as json and no longer use new-line (#55)
83ad938 
* fix(logging) encode try-list as json and no longer use new-line

New-line characters in the logging are impossible to parse
correctly so should be prevented.

fixes #52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tieske Tieske

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(logging) encode try-list as json and no longer use new-line Kong/lua-resty-dns-client
2 participants
@Tieske @p0pr0ck5