Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): fixable eslint-plugin-vuejs-accessibility issues [KHCP-11024] #2345

Merged
merged 9 commits into from
Aug 21, 2024
Merged

fix(*): fixable eslint-plugin-vuejs-accessibility issues [KHCP-11024] #2345

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
185dd04
chore(deps): add eslint-plugin-vuejs-accessibility [KHCP-11024]
portikM Aug 16, 2024
a31eba7
fix(*): fixable eslint-plugin-vuejs-accessibility issues [KHCP-11024]
portikM Aug 16, 2024
56739d8
fix: resolve conflicts
portikM Aug 21, 2024
2772098
chore(eslint): remove eslint-plugin-vuejs-accessibility [KHCP-11024]
portikM Aug 21, 2024
b50a5e1
chore: update lockfile
portikM Aug 21, 2024
cf2b9a1
fix(kcollapse): button type attribute [KHCP-11024]
portikM Aug 21, 2024
597bb4b
fix(kmultiselect): remove listitem role [KHCP-11024]
portikM Aug 21, 2024
3527068
fix(kselectitem, kmultiselectitem): role attributes [KHCP-11024]
portikM Aug 21, 2024
845abe4
test(kselect): fix component tests [KHCP-11024]
portikM Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/KCollapse/KCollapse.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
:aria-label="triggerLabel ? undefined : 'Toggle content'"
class="collapse-trigger-content"
data-testid="collapse-trigger-content"
role="button"
@click.prevent.stop="toggleDisplay()"
>
<slot name="trigger-content">
Expand Down
1 change: 1 addition & 0 deletions src/components/KMultiselect/KMultiselectItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
role="listitem"
>
<div
:aria-selected="item.selected"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: should this go on the parent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it belongs on the role="option" element. Same in KSelectItem

class="multiselect-item-container"
role="option"
>
Expand Down
3 changes: 2 additions & 1 deletion src/components/KSelect/KSelectItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
:key="item.key"
class="select-item"
:data-testid="`select-item-${item.value}`"
@click="handleClick"
>
<div
:aria-selected="item.selected"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: should this go on the parent?

class="select-item-container"
role="option"
>
Expand All @@ -14,6 +14,7 @@
:disabled="item.disabled === true ? true : undefined"
type="button"
:value="item.value"
@click="handleClick"
adamdehaven marked this conversation as resolved.
Show resolved Hide resolved
>
<span class="select-item-label">
<slot name="content">{{ item.label }}</slot>
Expand Down
Loading